search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

fixed apiversion clusterrolebinding.yaml and clusterrole.yaml #130

Closed tux2cool closed 1 year ago

tux2cool commented 1 year ago

this fixes issue 129 submitted by me.

tux2cool commented 1 year ago

LGTM

What does this mean? What needs to be done to get this merged in?

tux2cool commented 1 year ago

so what are we waiting on now? this is a blocker trying to get it fixed ASAP.

nitinmohan87 commented 1 year ago

@gargath @JoelSpeed Any chances of merging this? We would love to keep using this chart and we are currently blocked on this issue.

tux2cool commented 1 year ago

Have tested it and works with change on EKS 1.22 (where rbac.authorization.k8s.io must be v1)

So when will it be merged?

gabeio commented 1 year ago

Unfortunately this repo seems to be unmaintained (most recent commit ~2y ago), there seems to be a similar project for anyone who also has found themselves without wave: https://github.com/stakater/Reloader

github-actions[bot] commented 1 year ago

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

toelke commented 4 months ago

Thank you for the contribution. I will merge #112 instead of this, as it is the earlier contribution.