search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

hash binarydata in configmaps #151

Closed jabdoa2 closed 1 month ago

jabdoa2 commented 2 months ago

Fixes #73

toelke commented 1 month ago

How is the migration path here? Do the hashes of CMs/Secrets change? That would lead wave to restart all deployments when wave is updated.

Thank you for all your contributions over the last few days, I am looking through them.

jabdoa2 commented 1 month ago

How is the migration path here? Do the hashes of CMs/Secrets change? That would lead wave to restart all deployments when wave is updated.

Thank you for all your contributions over the last few days, I am looking through them.

Yes it will restart all deployments referencing a configmap. I would mention this in the release.

We could avoid it but would involve either another hashmap or format strings. In my opinion a restart is fine.