Closed jabdoa2 closed 1 month ago
Wave sets a default informer sync interval of 5m. Prior to 0.7 this has been needed to catch changes in configmaps/secrets which were created after the deployment. We actually used 1m before which cause a lot of stress on the API server.
1m
Luckily, this is no longer needed. I reduced it to the controller default of 10h. Guess this issue comment explains it well: https://github.com/kubernetes-sigs/controller-runtime/issues/521#issuecomment-518457302. Since we do not need any periodoc reconcile (anymore) we should reduce it accordingly.
I updated the README to make clear that you probably should not change this unless you run into bugs with stale resources.
Wave sets a default informer sync interval of 5m. Prior to 0.7 this has been needed to catch changes in configmaps/secrets which were created after the deployment. We actually used
1mbefore which cause a lot of stress on the API server.Luckily, this is no longer needed. I reduced it to the controller default of 10h. Guess this issue comment explains it well: https://github.com/kubernetes-sigs/controller-runtime/issues/521#issuecomment-518457302. Since we do not need any periodoc reconcile (anymore) we should reduce it accordingly.
I updated the README to make clear that you probably should not change this unless you run into bugs with stale resources.