Better children tracking

wave-k8s / wave

Kubernetes configuration tracking controller

Apache License 2.0

681 stars 81 forks source link

Better children tracking #173

Closed jabdoa2 closed 5 months ago

jabdoa2 commented 6 months ago

Properly track all children
Do not overwrite children if they are referenced multiple times
Track which keys are required and which are optional in a configmap/secret
Validate if our children have all required key (before: we only checked that the child existed)
Add logging + kubernetes events for scheduling enable/disable
Fix potential race in watcher code. We previously released the lock during watcher updates. There is a small chance that we might miss an updated child in a concurrent watcher. Not a huge chance but not impossible.

Fix #170 Fix #171 Fix #172

This fixes a few cases we found in production where pods were restarting after creation (in combination with cert-manager secrets which initiall miss a key). Other than that it performed very well.

On top of #169. We might want to merge that first.

toelke commented 6 months ago

As an aside: You know that github handles stacked PRs rather well? If you change the base of this PR to a feature branch, it will automatically change to go on top of main when that is merged

jabdoa2 commented 6 months ago

As an aside: You know that github handles stacked PRs rather well? If you change the base of this PR to a feature branch, it will automatically change to go on top of main when that is merged

I did not know. Unfortunately, I cannot select my other PR since the branch technically is in my github org and this PR is against the wave-k8s org. Should that still work?

toelke commented 6 months ago

Sorry, yes, that makes sense 🤦‍♂️

jabdoa2 commented 5 months ago

Thanks for merging this. Can you tag a release? I would like to roll out the official version :-)

toelke commented 5 months ago

It's on my todo-list for Monday. I noticed I had not written down what to do for a release and did not want to rush and make mistakes. Sorry for the delay.

jabdoa2 commented 5 months ago

It's on my todo-list for Monday. I noticed I had not written down what to do for a release and did not want to rush and make mistakes. Sorry for the delay.

No worries. Wont upgrade during the weekend anyway. We got a strict Tuesday to Thursday upgrade policy.

toelke commented 5 months ago

The release is done.