wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
681 stars 81 forks source link

Update kubebuilder #177

Closed jabdoa2 closed 1 month ago

jabdoa2 commented 1 month ago

Unfortunately, we currently cannot upgrade further to controller-runtime 0.19 due to issues with kubernetes 1.31 api and ginko v2. See https://github.com/kubernetes/code-generator/issues/177 for details. This should land in controller-runtime soonish.

toelke commented 1 month ago

Thank you for the contribution!

jabdoa2 commented 1 month ago

Can you tag a release in the next few days? We learned the hard way that using a 1.29 client on kubernetes 1.30 can still cause issues. By definition the api client is compatible for +/- one kubernetes version. However, we did not know that this does not apply to any alpha APIs. In this case the mutating webhook will simply remove those newer APIs in pods which can cause adverse side-effects in some charts.

toelke commented 1 month ago

Done, chart version 4.4.0.