wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
647 stars 82 forks source link

Support for CronJobs #27

Closed stuart-warren closed 5 years ago

stuart-warren commented 5 years ago

Add support for updating CronJobs as well as Deployments

wonderhoss commented 5 years ago

Hello Stuart,

Thanks for raising this. Could you elaborate a little bit on what your use case is?

For Deployments, Wave ensures that on configuration update, all running Pods are eventually restarted to pick up the new configuration.

For a CronJob, Pods are created when the timer triggers and then run to completion. If configuration changes between two invocations, the next one will by default use the new values.

In what situation would you need Wave to interact with CronJobs and what would the desired behaviour be in that case?

stuart-warren commented 5 years ago

you make a good point! 🤦‍♂️