Example configuration doesn't work with kustomize

wave-k8s / wave

Kubernetes configuration tracking controller

Apache License 2.0

647 stars 82 forks source link

Example configuration doesn't work with kustomize #36

Closed AssafKatz3 closed 5 years ago

AssafKatz3 commented 5 years ago

Hi, Running "kustomize build" on example configuration don't work since it uses "../rbac" and "../manager" while kustomize (2.0.1) assumes that it is under the folder which contains the kustomization.yaml, the error is:

Error: rawResources failed to read Resources: Load from path ../manager/manager.yaml failed: security; file '../manager/manager.yaml' is not in or below '/home/wave-master/config/default'

I moved both folder under default and modify the path accordingly. Thanks

JoelSpeed commented 5 years ago

I'm not a kustomize user personally. I wonder if updating our kubebuilder code generation would fix this 🤔

@AssafKatz3 Could you maybe go into more detail about the changes you made? I'm not following Perhaps a PR if you have the time?

AssafKatz3 commented 5 years ago

The changes (with changes for #37) are here

meganwalker-ibm commented 5 years ago

I've just opened a PR for this in #39 to show what worked for me in fixing the error.