search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
647 stars 82 forks source link

[IS-698] - Remove redundant Update matcher #51

Closed JoelSpeed closed 4 years ago

JoelSpeed commented 5 years ago

We replaced this Update matcher with the functional UpdateWithFunc matcher in some places and should therefore replace it everywhere and remove the (fundamentally) broken Update matcher.

theobarberbany commented 4 years ago

/test verify-manifests

theobarberbany commented 4 years ago

/test 1.13

pusher-ci commented 4 years ago

@JoelSpeed: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-wave-test-1.11 1e72a36e2fd9ef1266324777a6523b5ea83d2cb5 link /test 1.11

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
theobarberbany commented 4 years ago

/test 1.13

theobarberbany commented 4 years ago

/test 1.12