wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
681 stars 81 forks source link

Adjust resource requests #62

Closed JensErat closed 5 years ago

JensErat commented 5 years ago

With just 20Mi request/30Mi limits, my instance of the wave controller running in a Kubernetes cluster with only ~50 pods never really started. It was already stuck at the log line Starting metrics server.

Running the application locally in the debugger worked fine. The issue turned out to be starvation in garbage collection. Slightly increasing the memory requests resolved the issue entirely.

Experiments allowed stable (but slow) operations starting with 40Mi requests/limits; with 75Mi wave starts and performs required operations within few seconds. Proposing to set request=limit to get into guaranteed QoS class.

pusher-ci commented 5 years ago

Hi @JensErat. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 5 years ago

/ok-to-test