search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
681 stars 81 forks source link

kustomize-referenced RBAC rules do not include DaemonSet and StatefulSet permissions #63

Closed JensErat closed 3 years ago

JensErat commented 5 years ago

We have two sets of RBAC rules in conf:

$ find . -iname "*role*.yaml"
./config/default/rbac/rbac_role.yaml
./config/default/rbac/rbac_role_binding.yaml
./config/rbac/manager_role.yaml
./config/rbac/manager_role_binding.yaml

While rbac/manager-role.yaml also contains permissions for StatefulSets and DaemonSets, those referenced by Kustomize in default/rbac do not have them. Looks like they have been forgotten to sync when support for those resources was created?

There is a PR trying to tackle this in #56, but this has not been worked on for more than two months now.

github-actions[bot] commented 3 years ago

This issue has been inactive for 60 days. If the issue is still relevant please comment to re-activate the issue. If no action is taken within 7 days, the issue will be marked closed.

wonderhoss commented 3 years ago

Still needs a look.

wonderhoss commented 3 years ago

I believe this is resolved. If there is still an issue with the current kustomizations, please re-open.