search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
681 stars 81 forks source link

Add missing DaemonSet and StatefulSet permissions to Kustomize example #72

Closed Lngramos closed 5 years ago

Lngramos commented 5 years ago

Ensure that the example Kustomize config is in sync with the other (auto-generated) example config, by adding the missing DaemonSet and StatefulSet RBAC permissions.

p.s. the Kustomize config does not appear to be auto-generated by the make manifest command.

Aims to resolve issue: https://github.com/pusher/wave/issues/63

pusher-ci commented 5 years ago

Hi @Lngramos. Thanks for your PR.

I'm waiting for a pusher member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 5 years ago

/ok-to-test

JoelSpeed commented 5 years ago

/retest

Some flaky tests :/