wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

[IS-957] Log object and hash change that triggers rollout (WIP) #74

Closed theobarberbany closed 3 years ago

theobarberbany commented 4 years ago

WISOTT

This PR adds an in memory store for all child objects: A HashBank. When the podController instance hash changes this store is retrieved, updated and then diffed in order to determine which child object caused the podController instance hash to change.

Work in progress.

pusher-ci commented 4 years ago

@theobarberbany: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-wave-test-1.13 6c9c1a85630e5deee895d9f740e3d51dd0d230a6 link /test 1.13
pull-wave-test-1.12 6c9c1a85630e5deee895d9f740e3d51dd0d230a6 link /test 1.12

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
github-actions[bot] commented 3 years ago

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.

theobarberbany commented 3 years ago

Let's let this die. Should've been done with metadata / annotations on the k8s objects anyway...