search

wave-k8s / wave

Kubernetes configuration tracking controller
Apache License 2.0
646 stars 82 forks source link

Add --namespace flag #92

Closed jzelinskie closed 1 month ago

jzelinskie commented 3 years ago

Fixes #37.

After applying this patch, I wrote the RBAC for running in a namespace and everything functions perfectly.

wonderhoss commented 3 years ago

Thank you very much for that!

Any chance you could add a test case to ensure the namespace restriction is honoured? Since it is a property of controller-runtime, I think a single test case for, say, the Deployment reconcile loop should be sufficient.

github-actions[bot] commented 3 years ago

~This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.~

github-actions[bot] commented 2 years ago

This pull request has been inactive for 60 days. If the pull request is still relevant please comment to re-activate the pull request. If no action is taken within 7 days, the pull request will be marked closed.