search

wave-scattering / amos-try

1 stars 2 forks source link

Problem with mpar%rev #12

Closed kostyfisik closed 4 years ago

kostyfisik commented 4 years ago

---------- Forwarded message --------- From: Alexander Moroz wavescattering@yahoo.com Date: Sun, 9 Feb 2020 at 08:22 Subject: Re: any advice where the value of rev = mpar%rev is set ? To: Konstantin Ladutenko k.ladutenko@metalab.ifmo.ru

Note that with R(I):=r^2(\theta) and with c_min = 100.0 c_max = 100.0 a = 100.0001 in default.ini I don't understand why one gets rev=114.47150056960329 in rsp_spheroid and the code returns in tmatr

r(i)=13103.73317847153

???

If I set c_min = 10.0 c_max = 10.0 a = 10.0001 in default.ini,

one gets still rev=114.47150056960329 in rspspheroid and still r(i)=13103.70809172221 in tmatr???

Any explanation for it?

kostyfisik commented 4 years ago

@wvstring At the moment https://github.com/wave-scattering/amos-try/blob/master/cylinder2mod/axspartclnew4.f90#L1417 sets rev (and later on mpar%rev in the beginning of apml subroutine) to be the equivalent sphere radius of cylinder volume.

kostyfisik commented 4 years ago

As of after https://github.com/wave-scattering/amos-try/commit/3a29901e732dcb4a6a970b77360918e7199fbffd it seems to work much better for the case of sphere. It still need to be improved for the case of other particles shape, at the moment is is only correct for spheroid and for cylinder.

kostyfisik commented 4 years ago

@wvstring Is it solved now?

wvstring commented 4 years ago

Yes resolved! ... and it looks that I've finally found the bug preventing me to finalize the LeRu option. Just pushed amended tmatr_leru showing overlap of zq11 and qr, qi entries when breakpoint is set on l. 3750!!!!

 On Wednesday, February 19, 2020, 07:30:57 AM EST, Konstantin Ladutenko <notifications@github.com> wrote:

@wvstring Is it solved now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

kostyfisik commented 4 years ago

Ok, let me know if you need any help, I should be able to find a couple of spare hours during the weekend.

On Thu, Feb 20, 2020, 20:39 wvstring notifications@github.com wrote:

Yes resolved! ... and it looks that I've finally found the bug preventing me to finalize the LeRu option. Just pushed amended tmatr_leru showing overlap of zq11 and qr, qi entries when breakpoint is set on l. 3750!!!!

On Wednesday, February 19, 2020, 07:30:57 AM EST, Konstantin Ladutenko < notifications@github.com> wrote:

@wvstring Is it solved now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/wave-scattering/amos-try/issues/12?email_source=notifications&email_token=ABH7JPM3675AUPOWB6WFMFDRD255HA5CNFSM4KSCCIVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMPMDRA#issuecomment-589218244, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABH7JPI2GK7AVWJGV5UDYT3RD255HANCNFSM4KSCCIVA .