search

wavebeem / codehost

Code formatter for cohost
https://codehost.wavebeem.com/
MIT License
14 stars 4 forks source link

Added "GitHub Dark Default" theme #17

Closed SpiritAxolotl closed 5 months ago

SpiritAxolotl commented 5 months ago

Extension with this theme: https://marketplace.visualstudio.com/items?itemName=GitHub.github-vscode-theme

I've also published all the relevant original css colors in this gist.

It's worth noting that function parameters aren't orange. Compare these two images.

Codehost:

codehost

VSCode:

vscode

I couldn't figure out how to add them, or if they're even supported. Oh well.
It's also worth noting that the colored bracket pairs don't exist, but that's probably not a priority lol.

netlify[bot] commented 5 months ago

Deploy Preview for codehost-wavebeem ready!

Name Link
Latest commit 247ae07c09fa4e68b9458b2407ec8d1f4ddf7263
Latest deploy log https://app.netlify.com/sites/codehost-wavebeem/deploys/663a51993e735b00086ef741
Deploy Preview https://deploy-preview-17--codehost-wavebeem.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wavebeem commented 5 months ago

yeahhhh, vscode themes have a lot more "detail" possible due to having more named tokens than prism supports.

thanks for the new theme!

my only question is what's up with the package-lock.json change? it seems like a lot of packages were upgraded or something?

image

also, would these themes normally have a status bar color that's different? the other themes have been customized along the bottom with a little "footer" style

image

SpiritAxolotl commented 5 months ago

my only question is what's up with the package-lock.json change? it seems like a lot of packages were upgraded or something?

npm warned me of a few security vulnerabilities so I ran npm audit fix.

Screenshot 2024-05-06 at 10 54 39 PM

Feel free to revert that change if you want.

As for the second background color, I didn't realize it styled that aspect of it so let me fix that real quick haha.

I might help with contribution documentation at a later date if you're okay with that

wavebeem commented 5 months ago

I might help with contribution documentation at a later date if you're okay with that

yeah im up for further contribution!

feel free to use github discussions or issues as appropriate

you can message me on discord if it's more involved and you want to talk at length about it

is the theme ok to merge? i noticed your MR is marked as draft, but it looks ready to go to me!

SpiritAxolotl commented 5 months ago

yeah I marked it as a draft because I didn't know if the theme was "complete". seems it is, since you mentioned that vscode themes has more named tokens than prism.

as for the documentation, I'm supposed to be on break from social media right now (help github has become my new social media) so I can discuss when I'm not so busy with my schoolwork!

SpiritAxolotl commented 5 months ago

oh yeah you might wanna update the changelog

wavebeem commented 5 months ago

oops, thanks for the reminder. just added it and credited u