search

wavebitscientific / datetime-fortran

Date and time manipulation for modern Fortran
MIT License
137 stars 51 forks source link

configure is insensitive to FCFLAGS #31

Closed milancurcic closed 8 years ago

milancurcic commented 8 years ago

Specifying FCFLAGS when running configure, for example:

$ FCFLAGS=-O3 FC=ifort ./configure

does not affect what flags are being used when running make. In fact, the flags are always -Wall -O0 -C -fbacktrace, which are the gfortran flags hardwired in src/lib/Makefile.am:

# Items needed specifically by autotools
AM_FCFLAGS = -Wall -O0 -C -fbacktrace

Specifying FC works as expected.

@blippy can you look into this at your convenience? Thanks!

blippy commented 8 years ago

yes. I'll look into it.

blippy commented 8 years ago

I am discussing this issue over at http://stackoverflow.com/questions/35117315/so-what-is-am-fcflags , if you're interested. The consclusion so far is that I shouldn't set AM_FCFLAGS.

I will investigate further.

blippy commented 8 years ago

I "think" this is now fixed. I've done my own testing, and it looks OK.

It could definitely use some testing by others though, esp. where other compilers are concerned. I have not been able to perform configuration tests in the presence of alternative compilers.

milancurcic commented 8 years ago

Right, I believe this is fixed, I just forgot to close the issue few days ago. Thanks!!