search

wavebitscientific / datetime-fortran

Date and time manipulation for modern Fortran
MIT License
137 stars 51 forks source link

ISO 8601 support #43

Closed tcanich closed 7 years ago

tcanich commented 7 years ago

These changes add new functions, isoweekdayLong and isoweekdayShort, as well as tests for both functions. The purpose of the functions is to return the long and short weekday names when using ISO 8601 ordered day numbers from isoweekday.

Also, a small change to configure.ac to correct a syntax failure when executing configure. The error was noted with aclocal 1.15 and autoreconf 2.69. No testing was done with other versions of these tools.

tcanich commented 7 years ago

@milancurcic 881219e may not be needed if you are moving away from autotools to cmake. I didn't notice this change until I'd already committed to my fork and submitted the PR.

0f29b21 was intended to bring my fork up to date (in an effort to avoid the previous) and I didn't intend it to be included in this PR...I'm still a bit clumsy with github.

Thank you very much for datetime-fortran!

milancurcic commented 7 years ago

Thanks @tcanich, I have reviewed this and all looks OK. :+1:

About the build system, my plan was to keep both autotools and cmake as valid build options.

zbeekman commented 7 years ago

About the build system, my plan was to keep both autotools and cmake as valid build options.

bold move!

milancurcic commented 7 years ago

@zbeekman I am curious about your comment - anything I am not aware of? I was convinced that autotools and cmake are completely independent of each other and can co-exist happily, no?

zbeekman commented 7 years ago

Yes they certainly can, but now you have two build systems to update and keep in sync... I didn't mean to alarm you, but I find that one build system is a PITA enough to maintain as it is already, let alone two!

On Wed, Jan 4, 2017 at 3:54 PM Milan Curcic notifications@github.com wrote:

@zbeekman https://github.com/zbeekman I am curious about your comment - anything I am not aware of? I was convinced that autotools and cmake are completely independent of each other and can co-exist happily, no?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wavebitscientific/datetime-fortran/pull/43#issuecomment-270483809, or mute the thread https://github.com/notifications/unsubscribe-auth/AAREPELnjSVBYTtC63OcQJfsRQwbPTSGks5rPAcdgaJpZM4LaP3E .

milancurcic commented 7 years ago

@zbeekman OK, thanks, I thought that was what you had in mind.

I doubt that we will be adding many more source files to datetime-fortran in the future so maintaining this should be easy. If it turns out not to be, we will abandon autotools.