Build or supply a process for building with Widevine

Aubron commented 7 years ago

https://github.com/electron/electron/blob/master/docs/tutorial/using-widevine-cdm-plugin.md

Electron builds without widevine support, implying that DRM protected content can't play in Wavebox. I have a dream of using spotify with the platform, would really love to be able to have support for this, even if I have to build the executable myself.

Thomas101 commented 7 years ago

We are aiming to add support for widevine in an upcoming release.

At the moment if you grab the plugin from your chrome install in the same way that electron wiki describes, you can pass Wavebox the widevine-cdm-path and widevine-cdm-version arguments from the command line.

bslayton commented 6 years ago

I was able to get Spotify working by using widevine-cdm-path and widevine-cdm-version arguments like @Thomas101 suggested.

For anyone interested in Widevine, here are a few tips:

I had trouble finding both Widevine files (widevinecdm and widevinecdmadapter) in more recent versions of Chrome. I had to download Chrome version 59.0.3071.86, however I believe any build of version 59 will work.
On macOS, Widevine files can be found at /Applications/Google Chrome.app/Contents/Versions/<ChromeVersion>/Google Chrome Framework.framework/Versions/A/Libraries/WidevineCdm/_platform_specific. Visit link on electronjs github link above, for specific path locations for Windows and Linux
I recommend copying the widevine files to a safe place, and pass that filepath as arguments. I put mine in ~/.widevine
On macOS, you can create an Automator script using the terminal action. Save it and move it to your dock, or where you wish to have it. open -a "/Applications/Wavebox.app" --args --widevine-cdm-path=/Users/ben/.widevine/widevinecdmadapter.plugin --widevine-cdm-version=1.4.8.984

bslayton commented 6 years ago

@Thomas101, probably a longshot, but any ideas on a way to get media keys (play, pause, prev, next) on the keyboard working. I miss being able to control my music with the keyboard.

Thomas101 commented 6 years ago

@bslayton it is possible to do it that way. As for the keyboard bindings, we don't have support for this just yet, it's something we need to add cross-platform and then integrated into each service that uses it. Is it Spotify you're using in Wavebox or something else?

bslayton commented 6 years ago

I was using Spotify, which for the most part, works just fine. However, I decided to switch back to Spotify desktop client because Spotify's web player (https://open.spotify.com) would periodically downgrade the audio quality. I dug around for a few minutes but didn't find anything.

Spotify doesn't appear to have the ability to change audio quality through their web ui, and doesn’t persist from their desktop app to web ui either.

I'm not sure there's anything that can be done via Wavebox to fix this. Two potential ways I can think of at the moment, would be a js hack to force Spotify web to use higher quality audio files. The second would be, taking Spotify desktop and putting that into Wavebox. My understanding is that a large portion of Spotify desktop is actually html/js/css. I do not think it’s built on electron however (not that that’d be a deal breaker). Not sure, I honestly do not know very much about the internals. Just food for thought.

Also, Spotify web UI slightly slimmed down in comparison to Spotify desktop. Like myself, others may prefer the desktop ui/ux.

jmfederico commented 4 years ago

Now that Wavebox 10 uses Chromium instead of Electron, is this something you plan on implementing soon?