search

waveclaw / language-rpm-spec

Atom support for basic RPM specfiles
MIT License
3 stars 3 forks source link

changelogs grammar: Don't require @ in email #19

Closed ferdnyc closed 5 years ago

ferdnyc commented 5 years ago

Obfuscated email addresses such as "user AT gmail dot com" currently break the changelog grammar (disabling syntax highlighting on the line), since the grammar expects an @ sign in the address.

Some changelog formats have the address surrounded by angle brackets, so requiring the @ is overkill. In those formats we can accept any (<.*>) as an email address.

After: image

waveclaw commented 5 years ago

It is rather weird to have to support people's misguided attempts to evade simple SPAM harvester bots, but if the customers want it...

ferdnyc commented 5 years ago

It is rather weird to have to support people's misguided attempts to evade simple SPAM harvester bots

Well, it's not even so much wanting it, as encountering it. There are plenty of spec files out in the wild that contain email address strings without an @ sign, so it's nice for Atom to be able to process them correctly. Which now it can, thanks!