search

waveclaw / puppet-subscription_manager

Handle Client Registration to RedHat Satellite 6 or Katello
https://rhn.redhat.com
Other
6 stars 34 forks source link

Error installing package ($_pkg) - v2.2.2 #61

Closed Edmilson-JR closed 5 years ago

Edmilson-JR commented 6 years ago

Hi Waveclaw,

Do you still update code for Puppet 3 ?

If so, I'd like to do a PR to fix the following:

Agent's execution is returning an error at https://github.com/waveclaw/puppet-subscription_manager/blob/v2.2.2/manifests/install.pp#L41

The value provided to source attribute misses ::subscription_manager before ::ca_package_prefix, so Puppet can't find that package.

waveclaw commented 6 years ago

I do not actively maintain any Puppet 3 code bases anymore. I can review and accept non-conflicting Puppet 3 fixes, but the Puppet 3 code is no longer tested against or reviewed.

Edmilson-JR commented 6 years ago

Ok, thank you.

I'll do all the tests locally before the PR.

waveclaw commented 6 years ago

Do note that I may not be able to upload a module based on any 2.x tags or versions to the Puppet Forge.

waveclaw commented 5 years ago

Puppet 3 is EOSL and no longer supported.