search

waveclaw / puppet-subscription_manager

Handle Client Registration to RedHat Satellite 6 or Katello
https://rhn.redhat.com
Other
6 stars 34 forks source link

facter errors on unregistered system #94

Closed vchepkov closed 4 years ago

vchepkov commented 4 years ago

on servers not registered with a satellite fact puppet generates errors:

Error: Facter: error while resolving custom fact "rhsm_identity": Missing key or value to store

The problem is in code trying to cache a nil value: https://github.com/waveclaw/puppet-subscription_manager/blob/master/lib/facter/rhsm_identity.rb#L66-L68

vchepkov commented 4 years ago

I have tried to submit a fix, but robocop is too picky :(

waveclaw commented 4 years ago

Should be resolved by work for #96. Please retest with 5.4.1.

vchepkov commented 4 years ago

@waveclaw , I have tried version 5.4.1, works great, thank you!