wavedrom / lambda

λ
MIT License
0 stars 0 forks source link

'svg.wavedrom.com' doesn't seem to support config #8

Closed K4zuki closed 3 years ago

K4zuki commented 4 years ago

Please describe your system environment before submitting your Issue.


<img src="https://svg.wavedrom.com/{config:{bits: '32', lanes: '2'},reg: [{name: 'a', bits: 8},{name: 'b', bits: 8},{name: 'c', bits: 1,type:2}]}"/>
<img src="https://svg.wavedrom.com/{config:{skin:'narrow'},signal:[{name:'clk',wave:'p......'},{name:'bus',wave:'x.34.5x',data:'head body tail'},{name:'wire',wave:'0.1..0.'}]}"/>
drom commented 4 years ago

Yes, it seems like I overwrite config here: https://github.com/wavedrom/lambda/blob/master/index.js#L95 Will fix.

drom commented 4 years ago

@K4zuki I have published new version, please try.

K4zuki commented 4 years ago

@drom thanks for the fix. bitfield rendered as expected now, but the skin is still not applied.

drom commented 4 years ago

is it better now?

K4zuki commented 4 years ago

Thanks again for the update. It is better now but continues with certain code

This doesn't work:

{config:{skin:'narrow'},signal:[{name:'clk',wave:'p......'},{name:'bus',wave:'x.34.5x'},{name:'wire',wave:'0.1..0.'}]}

This works:

{config:{skin:'narrow'},signal:[{name:'clk',wave:'p......'},{name:'wire',wave:'0.1..0.'}]}
{config:{skin:'narrow'},signal:[{name:'clk',wave:'p......'},{name:'bus',wave:'x.34.5x'}]}
{config:{skin:'narrow'},signal:[{name:'clk',wave:'p......'},{name:'wire',wave:'0.1..0.'},{name:'bus',wave:'x.34.5x'}]}
drom commented 4 years ago

I think some of the images got cached and will show the same old image instead of rerendering. Please change some insignificant character to see new image.

drom commented 3 years ago

consider fixed