search

waveform80 / picamera

A pure Python interface to the Raspberry Pi camera module
https://picamera.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.57k stars 355 forks source link

Stereoscopic image capture at max_resolution fails #608

Open realizator opened 4 years ago

realizator commented 4 years ago

I have a Compute Module-based stereoscopic setup with the two V1 cameras. I'm trying to capture stereoscopic image (sbs) with the maximum sensor resolution and without decimate (i.e. 5184x1944) using PiCamera, and got an error: "Invalid resolution requested: %r" % (value,)"

The same with the 5120x1936 (height is multiple of 16, width is multiple of 128 for each camera).

But with the raspistill I can successfully capture stereoscopic image with these options. If it is possible to capture such an image with the PiCamera from Python? (excluding running of the raspistill as external program from Python)

6by9 commented 4 years ago

The test at https://github.com/waveform80/picamera/blob/master/picamera/camera.py#L2609 wants to account for stereoscopic.

realizator commented 4 years ago

Quick check with disabling this test leads to other errors (in self._enable_camera(), self._camera.enable(), raise PiCameraMMALError and finally "Failed to enable component: Out of resources"). Looks like this _maxresolution size test is used in other places, and simple trick I've try is not the way here.

6by9 commented 4 years ago

Most likely you'll need to increase max_still_width and max_preview_width (assuming SBS rather than TB stereo mode) at https://github.com/waveform80/picamera/blob/master/picamera/camera.py#L2303-L2307. Increase the height if using top/bottom, although it probably doesn't make much difference.

realizator commented 4 years ago

Ok, thank you, I will check this!

realizator commented 4 years ago

Well, your advice from https://github.com/waveform80/picamera/issues/608#issuecomment-582952672 works great, if I increase GPU_MEM in config.txt to 256 Mb. No any other code changes needed. With GPU_MEM 192Mb I get "Out of resources". Usually I use 128 Mb, and raspistill works fine. But looks like PiCamera needs more.

realizator commented 4 years ago

@6by9 I also have a bunch of other stereoscopic support questions (for example, top-bottom is broken, rotation is broken etc). I find a lot of comments in PiCamera documents, that the stereoscopic support is not fully tested (as the developer has no access to the stereoscopic hardware), and also that the latest 1.13 release was on Feb, 2017.

I can help with the stereoscopic hardware, and also give a description of a found bugs. Is @waveform80 has a time and interest to update stereoscopic support in the PiCamera?