search

wavefrontHQ / wavefront-cli

Wavefront CLI Tool
Apache License 2.0
5 stars 8 forks source link

added set -euo pipefail #13

Closed puckpuck closed 4 years ago

puckpuck commented 5 years ago

In some automated environments, errors can get gobbled up when the script is run. This will ensure they bubble up properly.

See: https://vaneyckt.io/posts/safer_bash_scripts_with_set_euxo_pipefail/

ustinov commented 4 years ago

@vikramraman WDYT should we do with this PR?

vikramraman commented 4 years ago

The script includes explicit error checking where relevant. Closing this for now, as it may introduce unintended error cases.