search

wavefrontHQ / wavefront-sdk-java

Wavefront Core Java SDK
Apache License 2.0
6 stars 24 forks source link

Consider removing Guava #212

Open abelsromero opened 2 years ago

abelsromero commented 2 years ago

In light of recent issues with wavefront-spring-boot maybe it would be good to consider removing guava from dependencies of this project too. This would alleviate packaging size and remove any need of shading.

I checked and it's using:

All but last 2 I think could easily be replaced by standard components & refactors. For RateLimiting we could look into resilience4j, for cache I don't have any suggestion. But we could start removing the first ones at least.

jonatan-ivanov commented 1 year ago

@oppegard We have more and more issues with Guava in Micrometer. :( What do you think, can it be removed from the Wavefront SDK or at least upgrade it?

oppegard commented 1 year ago

@jonatan-ivanov wavefront-sdk-java v3.2.0 bumped guava to 32.0.1. Will bumping to 32.1.1 in #286 address the micrometer issues for now?

jonatan-ivanov commented 1 year ago

I think bumping to 32.1.1-jre would help, could you please also make sure that the SDK does not depend on com.google.collections:google-collections or com.google.guava:listenablefuture? See: https://github.com/google/guava/releases/tag/v32.1.0#user-content-overlap

oppegard commented 1 year ago

@jonatan-ivanov I just released v3.2.1 with a bumped guava. I also verified we're not using com.google.collections:google-collections or com.google.guava:listenablefuture. Can you check if v3.2.1 resolves the issue with micrometer?

jonatan-ivanov commented 1 year ago

Thank you very much! Older version of Guava had a dependency on listenablefuture but now it is gone, thank you!