wavefunction91 / IntegratorXX

Reusable DFT Grids for the Masses
BSD 3-Clause "New" or "Revised" License
13 stars 9 forks source link

Do not use Approx in tests #44

Closed susilehtola closed 1 year ago

susilehtola commented 1 year ago

According to the Catch2 documentation

We strongly recommend against using Approx when writing new code. You should be using floating point matchers instead.

The tests should accordingly use

wavefunction91 commented 1 year ago

Interesting, I wasn't aware of this!

wavefunction91 commented 1 year ago

To avoid a ton of merge conflicts, this should be held off until after #27 is merged

wavefunction91 commented 1 year ago

Closed by #65