search

wavefunction91 / IntegratorXX

Reusable DFT Grids for the Masses
BSD 3-Clause "New" or "Revised" License
13 stars 9 forks source link

cmake target name #77

Closed loriab closed 1 year ago

loriab commented 1 year ago

(Sorry, hit enter too soon.) Anyway, to be brief, I think you're mentioning IntegratorXX::integratorxx but exporting IntegratorXX::IntegratorXX.

https://github.com/wavefunction91/IntegratorXX/blob/master/cmake/IntegratorXXConfig.cmake.in#L48 is the lowercase. Otherwise, easy enough to add at https://github.com/psi4/psi4/pull/3041

wavefunction91 commented 1 year ago

Yes, but I alias to the IntegratorXX::IntegratorXX target here https://github.com/wavefunction91/IntegratorXX/blob/master/CMakeLists.txt#L8

That should allow you to link downstream to the same target either source included or discovered. We do this in GauXC here https://github.com/wavefunction91/GauXC/blob/master/src/CMakeLists.txt#L75-L77

Does the location property deduction fail? I.e. is this alias causing build symptoms?

Edit: disregard, I just can't read apparently. Good catch

loriab commented 1 year ago

Thanks for the fix!