search

wavelab / ximea_ros_cam

Ximea ROS Camera
MIT License
14 stars 12 forks source link

open cv 3 isn't needed but is required in cmakelist. #1

Closed Asylbeck closed 6 years ago

Asylbeck commented 7 years ago

in line 23 of the Cmakelist: "find_package(OpenCV 3 REQUIRED)" can be replaced with "find_package(OpenCV REQUIRED)" the driver still builds and runs ok.
Checked the header - didn't find any CV3 specific headers. Installing openCV 3 might be an unnecessary and painful step for driver installation.

carloswanguw commented 6 years ago

Okay, I can create a branch for this. For the time being we will use OpenCV REQUIRED until there is a need for the new features from OpenCV 3

carloswanguw commented 6 years ago

Completed this with #5