waveshareteam / High-Precision-AD-DA-Board

42 stars 33 forks source link

Update config.py #12

Open userh23 opened 3 years ago

jesgome commented 2 years ago

Would you elaborate on why this is a better setting for SPI.max_speed_hz variable?

I can confirm that the code still compiles and reads well with your update. I just can't see what improvement it makes on what it was before.

Edit: I just tested data collection and can see that hi data throughput is much faster with your update. It may seem better at face value but I'm a little concerned this may affect measurement error tolerance. I'll respond with a reply later when I have a better sense of measurement error with your update.

Edit: I performed a rough test on measurement error tolerance and it does seem that this update has a minor increase in noise in the measurement of voltages. The increase is small and tolerable depending on what degree of certitude the user requires and if the speed increase is warranted for their application. I would still say leave the config.py module as is and do not merge this with the library but rest assured it will work if you choose to modify your own library.