waveshareteam / LCD-show

398 stars 179 forks source link

Absolutely abysmal scripts that are highly likely to brick your pi #17

Open Script-Nomad opened 4 years ago

Script-Nomad commented 4 years ago

I'll keep this brief... your scripts have multiple points of failure that should result in an abort or at the very least provide warnings, prompts, and debugging output to help narrow down the causes. These scripts have no such protections. For instance, cmake failed for me, resulting in no driver being built. Then it promptly overwrote critical files like my cmdline.txt and config.txt based on teh assumption that cmake would succeed and promptly rebooted without asking.

Needless to say, your script bricked my pi and obliterated a week's worth of work I had been doing to prepare a custom image.

You use hard-coded paths, and make a ton of assumptions based solely on the Rasbian image, overwrite files without backing them up, and make dozens of extremely destructive changes that universally result in a kernel panic if anything goes wrong. Can't you at least do some error handling FFS?

phixion commented 4 years ago

Yeah ...noone reads this it seems. There's PRs from a year ago. I was checking their github since I wasn't willing to insert a cd-rom from china into anything that can read it, when I stumbled upon their "scripts"

razgithub commented 4 years ago

Agree. These are pretty horrible! MHS35 would brick Arch in the Pi 4. As useless as the script is, though, its damage isn't difficult to undo.

Not that is related to bricking, but these don't even check if dpkg exists.