search

wavesoft / local-echo

A local-echo controller for xterm.js
Apache License 2.0
142 stars 71 forks source link

Update to work with xtermjs 4 #19

Closed coolreader18 closed 4 years ago

coolreader18 commented 4 years ago

This should still be compatible with xterm v3, though I haven't actually tested it. The onData and onResize methods have been there for a while (typescript typings for xtermjs 3.14), and in theory even the new addon system could be used in xtermjs 3.14, though the old way of passing a terminal to the constructor still works.

coolreader18 commented 4 years ago

@wavesoft would you be able to take a look at this?

wavesoft commented 4 years ago

Hello and thanks for the PR @coolreader18 ! Will have a look now

arthur5005 commented 4 years ago

It looks as if the reviewer suggestions have been applied in the latest commit. Can we expect this PR to be merged soon?

ppacory commented 4 years ago

is it ready for xtermjs 4.x ? can't find a release working with xtermjs 4.x

pre commented 4 years ago

How about ditching support for older xtermjs versions altogether? An older version of local-echo can be used with an oder xtermjs, but there is currently no version of local-echo that works with the current version of xtermjs.

RangerMauve commented 4 years ago

I just installed the branch from github and it's working great.

pre commented 4 years ago

I concur - master does not work but the branch of this PR does work.

I suggest a merge.

jasonolmstead33 commented 4 years ago

@wavesoft @coolreader18 any update on this? looking to get a local-echo working with xterm >= v4

RangerMauve commented 4 years ago

@jasonolmstead33 I suggest installing from the branch instead of the main repo. 😁

jasonolmstead33 commented 4 years ago

@RangerMauve thats what ive done for now, thanks, hoping we can get it as part of master :)

wavesoft commented 4 years ago

Hey guys! Sorry for the long absence, going to land this, run some checks and cut a new release 👍

RReverser commented 4 years ago

@wavesoft It looks like release hasn't been cut yet?

RReverser commented 4 years ago

@wavesoft Ping. Can you please at least add a prebuilt version to the repo? For now I can do npm install github:wavesoft/local-echo, but then need to cd node_modules && npm install && npm run build, which is quite tedious and error-prone.