wavestone-cdt / EDRSandblast

1.46k stars 272 forks source link

Fix multiple issues in offsets extractor #12

Closed laxa closed 11 months ago

laxa commented 1 year ago

This PR fix multiple issues in the extractor:

themaks commented 11 months ago

Hey ! Thanks for the contributions and the fixes! ("better late than never", but I'm really sorry for the delay ^^)

I took the liberty to edit your commits ; regarding "A crash in the version check of radare2 depending on the release taken", I already pushed a fix between the time of your PR and today, that seems to cover an additional format of radare2 version tag. If you have a test case that crash the current code, don't hesitate to share it in the code comment (see here) and fix the code if necessary Thanks for the rest!

PS : I failed to push the edited commits back inside this PR, somehow, they are in new commmit on master, see a561976b5dd700de6d0453a82715390c08e5f501 and 45d3ff5486ae795d362af5c9478b4467085bfc71