[Bug]: Cannot resize blocks in 0.9.2

wavetermdev / waveterm

An open-source, cross-platform terminal for seamless workflows

https://www.waveterm.dev

Apache License 2.0

4.52k stars 118 forks source link

[Bug]: Cannot resize blocks in 0.9.2 #1292

Open m0rg5 opened 1 week ago

m0rg5 commented 1 week ago

Current Behavior

The resize handles appear, but can't be dragged slimmer or wider.

It also seems unintuitive that the right sidebar creates new blocks when clicking (terminal, files, web, etc), seems this action should toggle a block (in chosen position) on or off, and perhaps holding a modifier, I.e. CTL, would open an additional block if wanted.

Expected Behavior

resize handles work as they did in 0.7

Steps To Reproduce

Macos m1, 0.9.2

Wave Version

0.9.2

Platform

macOS

OS Version/Distribution

No response

Architecture

arm64

Anything else?

No response

Questionnaire

[ ] I'm interested in fixing this myself but don't know where to start
[ ] I would like to fix and I have a solution
[X] I don't have time to fix this right now, but maybe later

esimkowitz commented 1 week ago

I can't reproduce this on my machine, can you share some more detailed steps to reproduce? A screen recording may also be useful.

You also mention that you're comparing resize handles to 0.7, but this was not a feature that we had in 0.7. 0.8 was a complete rewrite of our app so most things don't work the same as they did in 0.7. Can you elaborate on what your expected behavior is?

esimkowitz commented 1 week ago

As for the second part about having widget buttons in sidebar toggle existing blocks, that sounds like a feature suggestion rather than a bug. I would say open it as a separate feature request but honestly it's probably not something we'll pursue as it's not really compatible with our layout/block system. The idea of the blocks is that they're discrete entities that store their own state and are discarded when they close.

Additionally, the sidebar is going to be replaced pretty soon. We've got a few designs we're toying with that will make the widget picking experience more useful and will expand it to support other types of customization. We are also working on some designs for more ephemeral blocks (the first of these designs is actually already implemented and will ship with the next release).

m0rg5 commented 1 week ago

Hey, thx for response. I actually rolled back to 0.7.6, but I'd simply be showing you a screencast of mouse pointer turning to a resize icon and me not resizing the chat column/block smaller.

This is what I've got in 0.7.6:

If it's all going to change re: sidebars, best to wait and see!