search

wavetermdev / waveterm

An open-source, cross-platform terminal for seamless workflows
https://www.waveterm.dev
Apache License 2.0
4.45k stars 116 forks source link

MacOS prompts to install command line tools (running git) #301

Open sawka opened 9 months ago

sawka commented 9 months ago

Bug happens on MacOS when you don't have command line tools installed.

Wave tries to run git to check the current directory branch. If CLI tools are not installed MacOS it will pop up a system dialog asking to install CLI tools.

Wave should check to see if if CLI tools are installed. If they aren't (or if there is no git in the path) we shouldn't try to run git.

sawka commented 8 months ago

Actually not sure how to fix this. MacOS actually does have a git program installed that happens to send up the prompt. My (quick) internet searching didn't find a great way of knowing whether devtools are installed.

posguy99 commented 7 months ago

Actually not sure how to fix this. MacOS actually does have a git program installed that happens to send up the prompt. My (quick) internet searching didn't find a great way of knowing whether devtools are installed.

$ xcode-select -p
/Library/Developer/CommandLineTools