search

wavetermdev / waveterm

An open-source, cross-platform terminal for seamless workflows
https://www.waveterm.dev
Apache License 2.0
4.06k stars 97 forks source link

Default shell setting for Windows #856

Open esimkowitz opened 1 week ago

esimkowitz commented 1 week ago

Is your feature request related to a problem? Please describe.

On Mac and Linux, we honor the chsh settings for determining which shell to use. On Windows, we only support Windows Powershell.

Describe the solution you'd like

We should let users specify the default shell to use on Windows, including setting it to WSL, Cygwin, Git Bash, MSYS2, etc.

We can treat this somewhat like a remote, so that we don't need to relaunch the VM for each command, but we can make use of the filesystem access to use the installed WSH version, rather than needing to copy it over.

We should also support other native shells like Powershell Core and Command Prompt, though the latter is probably difficult just because it sucks (syntactically :P)

Soromeister commented 1 week ago

I literally just tried this out on Windows 11 and was genuinely confused as to where can I set the shell, only to not find any option whatsoever. Seeing this implemented would be considered a huge improvement over Windows Terminal given the plethora of features Waveterm has.

C0sm0cats commented 1 day ago

I completely agree with this suggestion! I would love to be able to use Git Bash on Windows. Having the option to set a default shell would be a significant improvement, especially for those of us who prefer development tools like Git Bash. It would enhance the user experience on Windows and provide a more consistent working environment. Thanks for considering this feature!

esimkowitz commented 1 day ago

WSL is being worked on currently, @oneirocosm can provide more details. Git-Bash, MSYS2, Docker, are also on our radar, as are AWS, Azure, and GCloud shells. Any others I'm missing?

C0sm0cats commented 22 hours ago

As an Arch Linux user, I value having my default shell (Zsh), and for work, I rely on the Windows version. Currently, being limited to PowerShell on Windows can be restrictive, so i fully support the idea of adding options for users to select their preferred shell, like Git Bash or WSL, as it would greatly enhance the overall experience. A more flexible environment would truly benefit developers.

@esimkowitz, it’s great to hear that other shells are being considered. Let’s also explore user-defined settings for even more customization. We could implement a setting that allows users to specify the path to their preferred shell. Alongside this, a toggle could enable users to easily switch between different shells. This combination would provide the flexibility to create a personalized environment that aligns with each developer's workflow.

I’m excited to see what other shells users are interested in! Let’s keep the conversation going !