search

wavexx / screenkey

A screencast tool to display your keys inspired by Screenflick
https://www.thregr.org/~wavexx/software/screenkey/
GNU General Public License v3.0
757 stars 66 forks source link

Way around using setuptools-git #30

Closed hotice closed 8 years ago

hotice commented 8 years ago

Is there a way around using setuptools-git? I'm asking because I maintain ScreenKey in my PPA for Ubuntu, Linux Mint, etc., and the Launchpad PPA build system doesn't allow downloading external tools, so the build system can't download setuptools-git, and thus, I can't build the latest screenkey 0.9 package, which depends on setuptools-git in setup.py, in the PPA.

Thanks!

hotice commented 8 years ago

I just removed "setuptools-git" from setup.py and everything seems to work ok. I assume doing this doesn't affect the app in any way?

wavexx commented 8 years ago

On Mon, May 16 2016, Andrew notifications@github.com wrote:

I just removed "setuptools-git" from setup.py and everything seems to work ok. I assume doing this doesn't affect the app in any way?

Check if language files are still built and installed correctly.

hotice commented 8 years ago

I see language files in the package built without setuptools-git for uk, fr, zh and es - screenshot: image

I assume it looks ok?

wavexx commented 8 years ago

Looks good. I removed it from the package_requires. I use it to generate the package with sdist, and while it's not required for build (or to be written in setup.py at all), sdist without setuptools-git installed will omit the language data.

On a related note, how do you feel about depending on python-glade? I'd like to remove some crufty code and use something more modern.

hotice commented 8 years ago

Thanks! Regarding python-glade, I'm not a software developer, so I can't comment on it :) From a packager point of view, anything that's available in the official repositories is ok :)

wavexx commented 8 years ago

Ok, closing this then.

Strange that setuptools-git isn't. It's a pretty common dependency in python packages nowdays. Or maybe not for end-user programs...

hotice commented 8 years ago

Both in Launchpad PPAs and in the official Ubuntu repositories, a package can be built only if its dependencies are available in the official repositories, and setuptools-git isn't...