partially fixing issue #43 - Githubissues

wavexx / screenkey

A screencast tool to display your keys inspired by Screenflick

https://www.thregr.org/~wavexx/software/screenkey/

GNU General Public License v3.0

758 stars 65 forks source link

partially fixing issue #43 #45

Closed khalilfazal closed 6 years ago

khalilfazal commented 7 years ago

What works:

[x] images for mouse buttons shows up properly: smooth transition between key presses (gtk.Label) and mouse clicks (gtk.Image)
[x] images for mouse buttons:
- [x] left, middle, and right mouse buttons
- [x] scroll up/down
- [x] scroll left/right

TODO:

[ ] Change the mouse image's aspect (size, color, opacity) with respect to options
[ ] add option to show the buttons on top of the cursor (requested by @ChameleonScales) instead of where keys normally appear on the bottom
[ ] add a mouse circling feature better than keymon's

ChameleonScales commented 7 years ago

Thank you very much for tackling this. I dowloaded the fork and ran screenkey but I don't see any mouse icon though.

khalilfazal commented 7 years ago

What's the output of running it in debug mode and mashing your mouse buttons? Mouse icon appears on mouse clicks.

screenkey -d

ChameleonScales commented 7 years ago

Nothing appears. Only when I press keys. I downloaded the fork here.

khalilfazal commented 7 years ago

Ah, that's the wrong link.
The link you just gave is a link to the master branch. This is the right link: https://github.com/khalilfazal/screenkey/tree/fork Sorry, I did it awkwardly.

You can tell by whether my commits are included or not.

ChameleonScales commented 7 years ago

Oh yes it works great now !

ChameleonScales commented 7 years ago

and you did the scroll wheel today

ChameleonScales commented 7 years ago

One issue though is that it disappears as soon as you hit a key and vice versa it would be great if both could be displayed together. So the icon would have to be on the left or right side to make room for the letters.

ChameleonScales commented 7 years ago

Also it has trouble changing the size : If you go bigger it changes the size as soon as you hit a key or mouse button but if you go smaller (large to medium or medium to small) it only works when you wait until the bar disappears and hit a key (not a mouse button).

ChameleonScales commented 7 years ago

2 other things :

The hatching filling of the buttons looks nice but I'd prefer them to be filled entirely to be more visible, especially when using the small display size. Having the choice between the 2 in the preferences would be the best.
(less important for me right now) the "Font color" property only applies to text, not the mouse icon. It would be great to have it work on both, although I know it's more complicated to implement.

wavexx commented 6 years ago

Should we close this in favor of #65, or there is something extra?

ChameleonScales commented 6 years ago

for what concerns me, we can close it, there's no additional functionality to it.

wavexx commented 6 years ago

Ok, closing then to reduce the list of duplicate PRs