search

waveygang / wfmash

base-accurate DNA sequence alignments using WFA and mashmap2
MIT License
172 stars 15 forks source link

return 1.0d ? #226

Closed NullModel closed 3 months ago

NullModel commented 5 months ago

What types of constants are this in the code:

wfmash/src/common/wflign/deps/atomic_image.cpp:95:39: error: invalid suffix 'd' on floating constant double u_rfpart(double x) { return 1.0d - u_fpart(x); }

gcc -v Apple clang version 15.0.0 (clang-1500.3.9.4) Target: x86_64-apple-darwin23.3.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin

AndreaGuarracino commented 3 months ago

Following #232's tips, I've removed those suffixes on float constants. This should improve clang compatibility.