search

wavezync / vue3-google-signin

Google OAuth2 plugin for Vue3 Apps. This uses latest Google Identity Service Library. It also provides set of composables which can be used easily to implement different authentication strategies
https://vue3-google-signin.wavezync.com/
MIT License
161 stars 17 forks source link

Remove 'cb triggered' console log #53

Closed oliver-youdooh closed 11 months ago

oliver-youdooh commented 1 year ago

Hi there,

Any chance of removing this debugging statement? Currently this is outputting in our production env. https://github.com/wavezync/vue3-google-signin/blob/2bdfffd29919e4df6cf857f3223c86673304d9fd/src/composables/useOneTap.ts#L222

I find it would be useful only in a development environment. Perhaps we can make this a development environment output instead?

if (process.env.NODE_ENV === "development") {
    console.log("cb triggered"); 
}

Happy to open a pull request if you like.

kasvith commented 1 year ago

sure, please open a PR :)

oliver-youdooh commented 1 year ago

@kasvith thanks! Opened PR #54

kasvith commented 11 months ago

Closed by #54