search

wavezync / vue3-google-signin

Google OAuth2 plugin for Vue3 Apps. This uses latest Google Identity Service Library. It also provides set of composables which can be used easily to implement different authentication strategies
https://vue3-google-signin.wavezync.com/
MIT License
161 stars 17 forks source link

Missing TypeScript Type Definitions in 1.3.4 Distribution #66

Closed SantonyChoi closed 7 months ago

SantonyChoi commented 7 months ago

Describe the bug

Hello,

I've noticed that the TypeScript type definitions, previously available in the dist folder, are missing in version 1.3.4 of vue3-google-signin. This change has led to TypeScript compilation errors in my project due to the missing type information.

As a temporary workaround, I have manually added the type definitions to my project like below, but it would be ideal to have them included in the package itself. import GoogleSignInButton from 'vue3-google-signin/dist/components/GoogleSignInButton.vue';

To Reproduce Steps to reproduce the behaviour:

  1. Import GoogleSigninButton to your project as described in README. import { CredentialResponse, GoogleSignInButton } from 'vue3-google-signin';
  2. See the type error.

Expected behaviour

  1. The import should return no type errors with the import like below. import { CredentialResponse, GoogleSignInButton } from 'vue3-google-signin';

Additional context It occurs in the development environment.

kasvith commented 7 months ago

Will check this

kasvith commented 7 months ago

i see, vite is not producing the right type defs

kasvith commented 7 months ago

Fixed in v1.3.5