wavezync / vue3-google-signin

Google OAuth2 plugin for Vue3 Apps. This uses latest Google Identity Service Library. It also provides set of composables which can be used easily to implement different authentication strategies
https://vue3-google-signin.wavezync.com/
MIT License
155 stars 17 forks source link

FedCM becomes mandatory #74

Open agracia-foticos opened 4 months ago

agracia-foticos commented 4 months ago

Describe the bug GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment

To Reproduce Steps to reproduce the behaviour:

  1. Go to https://vue3-google-signin.wavezync.com/guide/one-tap-login.html
  2. Sign in with one tap image
  3. In console there is this error: [GSI_LOGGER]: Your client application uses one of the Google One Tap prompt UI status methods that may stop functioning when FedCM becomes mandatory. Refer to the migration guide to update your code accordingly and opt-in to FedCM to test your changes. Learn more: https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#display_moment and https://developers.google.com/identity/gsi/web/guides/fedcm-migration?s=dc#skipped_moment

Reproducible Example If you can please provide a reproducible example with Stackbliz, CodeSandbox or any other suitable service

Expected behaviour A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

kasvith commented 4 months ago

Hey thanks for bringing attention to this

agracia-foticos commented 4 months ago

Hey thanks for bringing attention to this

Any idea of ​​the error? Can I bypass the error somehow?

kasvith commented 4 months ago

im checking the docs and trying to fix this in a new release

kasvith commented 4 months ago

it will be backward compatible for you

agracia-foticos commented 4 months ago

im checking the docs and trying to fix this in a new release

THANKS A LOT!!!

kasvith commented 4 months ago

as i checked we arent even using there methods, but still gets the warning. i will dig into this

agracia-foticos commented 4 months ago

as i checked we arent even using there methods, but still gets the warning. i will dig into this

Do you know approximately what deadlines you have for uploading the new version with the patch applied?

kasvith commented 4 months ago

I cant provide a deadline sadly

agracia-foticos commented 4 months ago

I cant provide a deadline sadly

We hope for news soon. If you need any other information, do not hesitate to ask.

kasvith commented 4 months ago

i still could not figure out this, we are not using any methods described by FedCM :(

infinnie commented 3 months ago

i still could not figure out this, we are not using any methods described by FedCM :(

Perhaps they enforce it automatically in supported browsers.

jsony commented 2 months ago

Has it been fixed?

kasvith commented 2 months ago

Hi all, unfortunately the fix is unclear for me. this library does not use anything which is not working with FedCM as i looked into

agracia-foticos commented 2 months ago

Any advance??

image

In your web also fails the login! :(

do you need another reproduction?

kasvith commented 2 months ago

hmm i can actually login with my browser(latest chrome)

have you enabled FedCM?

image

agracia-foticos commented 2 months ago

hmm i can actually login with my browser(latest chrome)

have you enabled FedCM?

image

image

versión of google chrome Versión 126.0.6478.126 (Build oficial) (64 bits)

image

kasvith commented 1 month ago

hi

i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard

agracia-foticos commented 1 month ago

hi

i was trying to replicate the issue. the main problem is we arent using any method indicated by GSI Logger, was wondering whether this is due to an outdated onetap api call. but its also the standard

Do you need anymore?

kasvith commented 1 month ago

Its bit confusing, if we at least use these deprecated methods its easier to remove them. but we dont use them at all. im not sure whether this is a false indicator

JasonMSims commented 4 weeks ago

@kasvith - these methods are defined in the PromptMomentNotification interface in interfaces/accounts.ts. According to the FedCM migration docs it looks like they should be removed altogether?

kasvith commented 4 weeks ago

@JasonMSims even they are defined they aren't being used anywhere

its mostly for the typescript stuff

i removed them locally and tried also, but same results