wavezync / vue3-google-signin

Google OAuth2 plugin for Vue3 Apps. This uses latest Google Identity Service Library. It also provides set of composables which can be used easily to implement different authentication strategies
https://vue3-google-signin.wavezync.com/
MIT License
161 stars 17 forks source link

ClientId may be undefined when using FedCM login #76

Closed infinnie closed 3 months ago

infinnie commented 5 months ago

Describe the bug When using FedCM sign-in in Google Chrome, the clientId field passed to the callback may be undefined.

To Reproduce Steps to reproduce the behaviour:

  1. Log in to Google Chrome
  2. Open a page that calls useOneTap() method to display Google’s OneTap sign in UI.
  3. When clicking Continue as [[your name]], onSuccess() is not called, and onError() is called without arguments.

Reproducible Example If you can please provide a reproducible example with Stackbliz, CodeSandbox or any other suitable service

Expected behaviour A clear and concise description of what you expected to happen.

Screenshots

image

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

kasvith commented 5 months ago

Hi, i still didnt have time to check with FedCM

kasvith commented 3 months ago

related #74