wawandco / milo

Milo is an HTML linter written in Go
MIT License
20 stars 0 forks source link

Reviewers Name Format #74

Closed paganotoni closed 4 years ago

paganotoni commented 4 years ago

As one of the steps we give in terms of categorizing is to standardize the way we name our reviewers (the string that returns the Name method of the reviewer interface).

My proposal is to name our reviewers with the following structure:

[thing]-[observed behavior]

Which will cause some changes in our reviewer names. For example:

attr-no-spaces page-no-inline-style (for css/inline) doctype-present page-no-inline-javascript (for script/inline)

But will build the base for reviewer naming conventions in the future.

paganotoni commented 4 years ago

cc @larrymjordan @tatang26