wawandco / visho

VSCode extension to boost your Plush productivity to the moon.
https://marketplace.visualstudio.com/items?itemName=wawandco-tools.visho
MIT License
7 stars 0 forks source link

Color highlighting of helpers / functions compared to erb #9

Open saurori opened 1 year ago

saurori commented 1 year ago

👋 Hey - thanks for creating this extension. I have been using erb as a Language Mode for .plush.html templates, which works well. When comparing this extension to erb, I noticed that variable/object highlighting in helper functions takes the same color as strings, or is just white. It would help to differentiate. See the images for an example:

ERB: Imgur

Visho: Imgur

Also sometimes the params are just white:

ERB: Imgur

Visho: Imgur

YanDeLeon commented 1 year ago

Hey @saurori 👋🏼!! Thank you for taking the time and open this Issue. It is a very good point.

For sure we'll work on that

paganotoni commented 1 year ago

Hey @saurori, there have been some improvements to this that I wanted to bring up with you. So far this is how it's looking:

CleanShot 2022-11-29 at 15 52 25@2x
saurori commented 1 year ago

@paganotoni Looks better! I do prefer the color scheme on the erb highlighting though (I'm using the Dark+ theme).

Imgur

Imgur