Closed JoshuaGross closed 7 years ago
Thanks Joshua! I'll merge this in and add the code generation.
On Sat, Oct 17, 2015 at 12:40 AM, Joshua Gross notifications@github.com wrote:
I believe this is end-user-API compatible with previous implementation, but the source generation needs to be updated. More-or-less a direct
translation of Match4.
You can view, comment on, or merge this pull request online at:
https://github.com/orlandohill/waxeye/pull/24 Commit Summary
- Initial stab at rewriting Waxeye JS client in a non-recursive architecture, based on the Standard ML implementation.
- Complete test fixtures and finish all features for new Waxeye Javascript machine.
- Include Javascript unit tester.
- Move Javascript test into the test directory.
- Remove original waxeye.coffee/js and replace with new, non-recursive implementation.
- Merge remote-tracking branch 'origin/master'
- Remove unnecessary console logs.
File Changes
- M README.md https://github.com/orlandohill/waxeye/pull/24/files#diff-0 (4)
- M src/javascript/waxeye.coffee https://github.com/orlandohill/waxeye/pull/24/files#diff-1 (623)
- M src/javascript/waxeye.js https://github.com/orlandohill/waxeye/pull/24/files#diff-2 (796)
- A src/test-fixtures.json https://github.com/orlandohill/waxeye/pull/24/files#diff-3 (336)
- A test/javascript/test.js https://github.com/orlandohill/waxeye/pull/24/files#diff-4 (150)
Patch Links:
- https://github.com/orlandohill/waxeye/pull/24.patch
- https://github.com/orlandohill/waxeye/pull/24.diff
— Reply to this email directly or view it on GitHub https://github.com/orlandohill/waxeye/pull/24.
Sounds good. Any ETA? I'm happy to help with code generation for the Java and C implementations (coming soon) once this one is done.
By the end of Wednesday, if not tomorrow. Sorry for the delay.
Yes, it'd be great if you could help with Java and C.
Appreciate it! I'm in a rush on my end but I realize my deadlines aren't your concern. Really appreciate the help.
Any updates on this?
Hey Orlando :) Any chance you'll still be able to look at this?
Hey Joshua, Yes, sorry. Haven't had as much spare time and energy as had hoped.
I'll look through it on the weekend, and send you an update. On Dec 7, 2015 1:05 AM, "Joshua Gross" notifications@github.com wrote:
Hey Orlando :) Any chance you'll still be able to look at this?
— Reply to this email directly or view it on GitHub https://github.com/orlandohill/waxeye/pull/24#issuecomment-162362299.
I believe this is end-user-API compatible with previous implementation, but the source generation needs to be updated. More-or-less a direct translation of Match4.