search

waxeye-org / waxeye

Waxeye is a parser generator based on parsing expression grammars (PEGs). It supports C, Java, JavaScript, Python, Racket, and Ruby.
https://waxeye-org.github.io/waxeye/index.html
Other
235 stars 38 forks source link

JavaScript: Do not require('assert') #75

Closed glebm closed 6 years ago

glebm commented 6 years ago

Removes require('assert'), as the current version causes compiler and linter warnings, and fixing the checks to be safe is not worth the effort since we only ever use the trivial assert.ok.

Enables strict mode for the file ("use strict";).

Compiles waxeye.coffee with the latest coffeescript (v2.0.1).

glebm commented 6 years ago

Note that this PR is superseded by #78, but it might be useful to merge this first anyway so that there is an intermediate commit that still has the old JavaScript parser but with the warning fixed.

orlandohill commented 6 years ago

Thanks!

Yes, doing an intermediate commit makes sense to me.