search

waxim / Gins

Gins - A gender/pronoun library for PHP
19 stars 5 forks source link

Troll-proofing via dependency injection #6

Open ianfixes opened 7 years ago

ianfixes commented 7 years ago

I noticed #2 and #5, which gave me a chuckle but probably have no place in this project.

Is there any reason that the classes here

couldn't be replaced by some injected JSON?

That way, site-specific overrides could be provided for folks who feel a moral obligation to push the boundaries here, and you wouldn't become an arbiter of what goes on that list of classes. I'd be happy to submit a PR for this if you like, although it would (by nature) affect the existing structure a fair amount.

waxim commented 7 years ago

I guess they could be. The problem I was having was the fact that a version of each pronoun is needed, so I wanted to enforce some schema on that but in light of alot of the feedback and the translations asked for I'm going to look at a refactor and maybe provide my list as a "plugin" instead of the basis.