search

waxlamp / nightshade

Tools for retrieving movie data from Rotten Tomatoes
Apache License 2.0
1 stars 0 forks source link

No output #19

Closed jimlynnjulian closed 1 year ago

jimlynnjulian commented 1 year ago

Using the Pypi pip install version in Windows 11 x64 Pro , MS-DOS CLI..

C:\Users\jimly\Downloads\Rotten Tomatoes scrapers\nightshade-0.1.0.tar\nightshade-0.1.0>nightshade search -s "https://www.rottentomatoes.com/m/matrix" No output.

C:\Users\jimly\Downloads\Rotten Tomatoes scrapers\nightshade-0.1.0.tar\nightshade-0.1.0>nightshade search -s "Matrix" No output.

C:\Users\jimly\Downloads\Rotten Tomatoes scrapers\nightshade-0.1.0.tar\nightshade-0.1.0>nightshade search -s "Matrix" -y "1999" No output.

waxlamp commented 1 year ago

Unfortunately, RT changes their webpage structure often, and this tool requires updates to its parser in order to keep up. If you feel like updating the code until it works again, I'm glad to accept a PR. Otherwise, I will get to it eventually myself, but it may be a while as life is getting in the way.

Since this will be a continuing problem for this software, I'm going to close the issue, but please don't take that as my dismissing the bug report -- it's just that it's an expected failure for this mode of web scraping.

jimlynnjulian commented 1 year ago

Thanks for the notice.