search

way-cooler / rust-wlc

[DEPRECATED] Rust bindings for wlc, the Wayland compositor library
54 stars 12 forks source link

derive Copy, prefer by-copy parameters #43

Closed serprex closed 8 years ago

serprex commented 8 years ago

Attempts to cover the bullets for Add Copy trait for Point/Size/Geometry & Functions take copyable types instead of references to them

Also uses std::mem::uninitialized::<[c_char; 64]>() over Vec::with_capacity(64) in xkb & bumps crate versions

serprex commented 8 years ago

Oops, going to resubmit PR for development branch

(nevermind, seems development is very stale..)

Timidger commented 8 years ago

:tada: Awesome, thanks so much for your contribution. We'll review it tonight.

SnirkImmington commented 8 years ago

We made some notes, we'd like to return Option for some of the types where the extern code could be returning null.

Thank you for the request, we've been busy with Way Cooler, we'll be sure to integrate these changes in with our optional Wayland dependency.