search

way2muchnoise / JustEnoughResources

A rewrite of NotEnoughResources using JustEnoughItems
Other
116 stars 62 forks source link

[Bug]: Villagers names on trading tab not translated #457

Open ffuentesm opened 4 months ago

ffuentesm commented 4 months ago

What happened? Would be nice to fix this long string name for their proper name. image

Minecraft Version: 1.20.1 Ice and Fire version: iceandfire 2.1.13-1.20.1+build.beta-2 JER: JustEnoughResources-1.20.1-1.4.0.247 JEI: jei-1.20.1-forge-15.3.0.4

AlpackPL commented 3 weeks ago

May i add mod to this thread? similiar situation is with AE2 and Villagers Plus image image

AlpackPL commented 3 weeks ago

Minecraft Version 1.20.1 Forge: 47.3.0 JEI: jei-1.20.1-forge-15.3.0.7 JER: JustEnoughResources-1.20.1-1.4.0.247.jar AE2: appliedenergistics2-forge-15.2.3 Villager Plus: VillagersPlus3.1(FORGE)_for_1.20.1

pskfyi commented 2 weeks ago

I had the same issue with the Tailor from Sewing Kit and I was just able to solve this by adding the following entry to the en_us.json file via a resource pack:

// assets/sewingkit/lang/en_us.json
{
   "entity.minecraft.villager.tailor": "Tailor"
}

This entry was not in the the file originally, but I noticed such an entry was present in other modded professions which were displaying correctly.